Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rule update (Anonymous Request Allowed): update to checking auth deci… #1267

Merged
merged 1 commit into from
Jun 19, 2020

Conversation

Kaizhe
Copy link
Contributor

@Kaizhe Kaizhe commented Jun 18, 2020

…sion equals to allow

Signed-off-by: kaizhe derek0405@gmail.com

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

If contributing rules or changes to rules, please make sure to also uncomment one of the following line:

/kind rule-update

/kind rule-create

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area engine

/area rules

/area tests

/area proposals

What this PR does / why we need it:
According to https://github.com/kubernetes/apiserver/blob/51732c2088edfd6d1d5ed5d48f61b7c1b91bf593/pkg/endpoints/filters/authorization.go#L39,

The auth decision can either be allow or forbid. In the rule we check with reject which is wrong.

Which issue(s) this PR fixes:
N/A

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

rule(Anonymous Request Allowed): update to checking auth decision equals to allow

…sion equals to allow

Signed-off-by: kaizhe <derek0405@gmail.com>
@Kaizhe Kaizhe requested review from mstemm and fntlnz June 18, 2020 18:57
@poiana poiana requested a review from mfdii June 18, 2020 18:59
@Kaizhe Kaizhe removed the request for review from mfdii June 18, 2020 19:08
@poiana
Copy link

poiana commented Jun 18, 2020

LGTM label has been added.

Git tree hash: 8fb438b219d2bb2af18c9149065f2e274824d127

@poiana
Copy link

poiana commented Jun 19, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fntlnz, mstemm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit dee0cc6 into master Jun 19, 2020
@poiana poiana deleted the kh_update-anonymous-request-allowed branch June 19, 2020 13:33
@leodido leodido added this to the 0.24.0 milestone Jun 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants