rule(macro root_dir): correct macro to exactly match the /root dir and not other with just /root as a prefix
#1279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
|
/milestone 0.24.0 |
|
/cc @Kaizhe |
fntlnz
previously approved these changes
Jun 25, 2020
leodido
previously approved these changes
Jun 25, 2020
Kaizhe
suggested changes
Jun 25, 2020
|
/hold |
Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
|
Change requested applied by 5f0d1b8 Please review again /hold cancel Thanks! |
|
LGTM label has been added. Git tree hash: 35335c202f492ebad59b38f842556ffe256ed5c4
|
leodido
approved these changes
Jun 26, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Kaizhe, leodido The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
/kind rule-update
Any specific area of the project related to this PR?
/area rules
What this PR does / why we need it:
👉 #1141
Which issue(s) this PR fixes:
Fixes #1141
Special notes for your reviewer:
Does this PR introduce a user-facing change?: