Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update k8s audit endpoint to /k8s-audit everywhere #1292

Merged
merged 1 commit into from
Jul 1, 2020

Conversation

fntlnz
Copy link
Contributor

@fntlnz fntlnz commented Jul 1, 2020

Co-Authored-By: Leonardo Di Donato leodidonato@gmail.com
Signed-off-by: Lorenzo Fontana lo@linux.com

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Related to #1026

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

update: k8s audit endpoint now defaults to /k8s-audit everywhere

Co-Authored-By: Leonardo Di Donato <leodidonato@gmail.com>
Signed-off-by: Lorenzo Fontana <lo@linux.com>
@fntlnz
Copy link
Contributor Author

fntlnz commented Jul 1, 2020

Related to #1261

@leodido
Copy link
Member

leodido commented Jul 1, 2020

/assign @fntlnz

@fntlnz
Copy link
Contributor Author

fntlnz commented Jul 1, 2020

/cc @leodido

@poiana poiana requested a review from leodido July 1, 2020 09:43
@poiana
Copy link

poiana commented Jul 1, 2020

LGTM label has been added.

Git tree hash: a09a04a00ef90a3f6add57855261f4f026243775

@poiana poiana added the approved label Jul 1, 2020
Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch.

LGTM

@poiana
Copy link

poiana commented Jul 1, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leodido, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 3523074 into master Jul 1, 2020
@poiana poiana deleted the fix/audit-endpoint branch July 1, 2020 11:29
@fntlnz
Copy link
Contributor Author

fntlnz commented Jul 1, 2020

mmm poiana has something wrong - an approve from a non owner should not trigger a merge :/

@leodido
Copy link
Member

leodido commented Jul 1, 2020

/milestone 0.24.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants