Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct stdout output buffering option #1296

Merged
merged 1 commit into from
Jul 3, 2020
Merged

Conversation

leogr
Copy link
Member

@leogr leogr commented Jul 2, 2020

What type of PR is this?

/kind bug

Any specific area of the project related to this PR?

/area engine

What this PR does / why we need it:

buffered_output: false was not honored for stdout.

This PR corrects the argument wrongly passed to the stdout_message that caused the problem aforementioned.

Which issue(s) this PR fixes:

Fixes #1198
Fixes #1291

Special notes for your reviewer:

I will add some comments for further improvement.

/cc @fntlnz
/cc @leodido

/milestone 0.24.0

Does this PR introduce a user-facing change?:

fix(userspace/falco): correct options handling for `buffered_output: false` which was not honored for the `stdout` output

This explain why `buffered_output: false` was not honored for stdout

Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
Copy link
Member

@leodido leodido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really good catch! Grazie!

Copy link
Contributor

@fntlnz fntlnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! LGTM

@poiana
Copy link

poiana commented Jul 2, 2020

LGTM label has been added.

Git tree hash: 17a01a8e21096ce4b8b9c263d30521da8c4464c9

1 similar comment
@poiana
Copy link

poiana commented Jul 2, 2020

LGTM label has been added.

Git tree hash: 17a01a8e21096ce4b8b9c263d30521da8c4464c9

@poiana
Copy link

poiana commented Jul 2, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fntlnz, leodido

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana added the approved label Jul 2, 2020
@poiana
Copy link

poiana commented Jul 2, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fntlnz, leodido

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@leogr leogr changed the title wip: correct stdout output buffering option correct stdout output buffering option Jul 2, 2020
@leogr
Copy link
Member Author

leogr commented Jul 2, 2020

/honk

@poiana
Copy link

poiana commented Jul 2, 2020

@leogr:
goose image

In response to this:

/honk

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@poiana poiana merged commit fecf1a9 into master Jul 3, 2020
@poiana poiana deleted the fix/stdout-buffering branch July 3, 2020 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GKE - Falco Logs not appearing for up to 10 minutes Falco took so long to write a JSON output log to stdout
4 participants