Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rules update(Read sensitive file untrusted): add trusted images into … #1327

Merged
merged 2 commits into from Jul 25, 2020

Conversation

Kaizhe
Copy link
Contributor

@Kaizhe Kaizhe commented Jul 23, 2020

…whitelist

Signed-off-by: kaizhe derek0405@gmail.com

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

If contributing rules or changes to rules, please make sure to also uncomment one of the following line:

/kind rule-update

/kind rule-create

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area engine

/area rules

/area tests

/area proposals

What this PR does / why we need it:

Reduce false positive

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

rule(Read sensitive file untrusted): add trusted images into whitelist

…whitelist

Signed-off-by: kaizhe <derek0405@gmail.com>
rules/falco_rules.yaml Outdated Show resolved Hide resolved
Signed-off-by: kaizhe <derek0405@gmail.com>
@poiana
Copy link

poiana commented Jul 23, 2020

LGTM label has been added.

Git tree hash: f96a0eeb8a4a4b58a0a8db082c4e89b785a03f00

@poiana
Copy link

poiana commented Jul 24, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fntlnz, mstemm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Kaizhe Kaizhe removed the request for review from leodido July 24, 2020 17:25
@poiana poiana merged commit 571f8a2 into master Jul 25, 2020
@poiana poiana deleted the kh_extend-whitelist-in-rule-read-files-untrusted branch July 25, 2020 06:53
@leogr leogr added this to the 0.25.0 milestone Aug 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants