fix(userspace/falco): do not always rethrow the exception #1366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Lorenzo Fontana <fontanalorenz@gmail.com> Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
leogr
force-pushed
the
fix/modprobe-fallback
branch
from
68617b8
to
4e4d52c
Compare
fntlnz
approved these changes
Aug 25, 2020
|
LGTM label has been added. Git tree hash: 6cfeb2f0f397a0da76a4c4ce4bae78c6dce5f4a8
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fntlnz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Any specific area of the project related to this PR?
/area engine
What this PR does / why we need it:
We have noticed that the kernel module was not loaded always when using Falco deb/rpm packages.
When we had investigated the fallback mechanism included in those scripts (see #1365 ) we then noticed that the Falco binary is loading the module by itself at some point.
Unfortunately, the implementation was thrown an exception even if it was able to load the module correctly.
This PR just fixes the case when
open_fworks aftermodprobethus the exception must not be thrown and the execution can continue normally.Which issue(s) this PR fixes:
Fixes #1347
Special notes for your reviewer:
/milestone 0.25.0
/cc @fntlnz
Does this PR introduce a user-facing change?: