Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable "Packet socket created in container" by default. #1402

Merged
merged 1 commit into from
Sep 18, 2020

Conversation

rung
Copy link
Contributor

@rung rung commented Sep 15, 2020

Signed-off-by: Hiroki Suezawa suezawa@gmail.com

What type of PR is this?
/kind rule-update

Any specific area of the project related to this PR?
/area rules

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

rule(macro consider_packet_socket_communication): enable "Packet socket created in container" rule by default.

fntlnz
fntlnz previously approved these changes Sep 15, 2020
@poiana
Copy link

poiana commented Sep 15, 2020

LGTM label has been added.

Git tree hash: 7e7268728ce7e5eef378b85cada3e3109cad2f76

@fntlnz
Copy link
Contributor

fntlnz commented Sep 15, 2020

Thanks @rung !

@Kaizhe PTAL :)

leodido
leodido previously approved these changes Sep 15, 2020
Copy link
Member

@leodido leodido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@Kaizhe
Copy link
Contributor

Kaizhe commented Sep 15, 2020

I am on paternity leave now so I will defer to @mstemm , for not blocking the PR review.

leogr
leogr previously approved these changes Sep 16, 2020
@leogr
Copy link
Member

leogr commented Sep 17, 2020

I'm closing and re-opening this to let GitHub checks start again

@leogr leogr closed this Sep 17, 2020
@leogr leogr reopened this Sep 17, 2020
@fntlnz fntlnz closed this Sep 17, 2020
@fntlnz fntlnz reopened this Sep 17, 2020
@fntlnz
Copy link
Contributor

fntlnz commented Sep 17, 2020

This seems to be stuck. I'll look at the web hooks. Thanks for the patience @rung

@rung
Copy link
Contributor Author

rung commented Sep 17, 2020

Thanks! no problem.
if I can do something to resolve the issue, feel free to ask me 👍

@fntlnz
Copy link
Contributor

fntlnz commented Sep 17, 2020

The webhook was fine, looks like circleci is not keeping it.
image

@rung

This comment has been minimized.

…lways_true

Signed-off-by: Hiroki Suezawa <suezawa@gmail.com>
@rung rung dismissed stale reviews from leogr and leodido via 7841993 September 18, 2020 00:30
@rung
Copy link
Contributor Author

rung commented Sep 18, 2020

let me rebase master, and force push to re-run CI 👍

@rung
Copy link
Contributor Author

rung commented Sep 18, 2020

🎉 It seems I had to refresh CircleCI settings on my side. The CI passed finally 😄

@fntlnz @leodido @leogr
Thank you for checking the CI status. Could you review this PR again when you have a time?

Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@poiana poiana added the lgtm label Sep 18, 2020
@poiana
Copy link

poiana commented Sep 18, 2020

LGTM label has been added.

Git tree hash: 6d1bb0195b7edda951fd767232dc55e4a528a081

@poiana
Copy link

poiana commented Sep 18, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fntlnz, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 5b92638 into falcosecurity:master Sep 18, 2020
@krisnova krisnova added this to the 0.26.0 milestone Sep 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants