update(scripts): driver loader cycles available gcc versions #1408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The falco-driver-loader script calls dkms to compile the kernel module using the default gcc. In some systems, and in the falcosecurity/falco container image, the defult gcc is not the right one to compile it. The script will try to compile the module by cycling trough all the available GCCs starting from the default one until the module is compiled the first time. The default gcc is the highest priority while trying. Newer GCCs have the priority over older GCCs. Co-Authored-By: Leonardo Di Donato <leodidonato@gmail.com> Signed-off-by: Lorenzo Fontana <fontanalorenz@gmail.com>
leodido
approved these changes
Sep 16, 2020
|
LGTM label has been added. Git tree hash: b18ea22ac33d85a3ee42c543c0ffa3b800798f16
|
|
/milestone 0.26.0 |
leodido
changed the title
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: leodido, leogr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The falco-driver-loader script calls dkms to compile the kernel
module using the default gcc.
In some systems, and in the falcosecurity/falco container image,
the defult gcc is not the right one to compile it.
The script will try to compile the module by cycling trough all the available GCCs
starting from the default one until the module is compiled the first
time.
The default gcc is the highest priority while trying.
Newer GCCs have the priority over older GCCs.
Co-Authored-By: Leonardo Di Donato leodidonato@gmail.com
Signed-off-by: Lorenzo Fontana fontanalorenz@gmail.com
What type of PR is this?
/kind feature
/area build
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #1407
Special notes for your reviewer:
Does this PR introduce a user-facing change?: