fix(test): make integration tests properly fail #1439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leodido
changed the title
|
/cc @leodido |
leogr
force-pushed
the
fix/integration-test
branch
from
c7956dc
to
54bfdf8
Compare
|
/hold |
leogr
force-pushed
the
fix/integration-test
branch
from
40257c1
to
3b11bf9
Compare
leogr
changed the title
leogr
changed the title
leogr
force-pushed
the
fix/integration-test
branch
from
99a2d30
to
91f0c7f
Compare
leodido
previously approved these changes
Oct 12, 2020
|
LGTM label has been added. Git tree hash: 88e62af2d963a44f7a1546e46d4b3fbc1f860ea6
|
leogr
force-pushed
the
fix/integration-test
branch
from
91f0c7f
to
eb0d847
Compare
leodido
previously approved these changes
Oct 12, 2020
|
LGTM label has been added. Git tree hash: 74821a12d89f189410b80265452b16245a13e29d
|
leogr
force-pushed
the
fix/integration-test
branch
from
14fd25d
to
eb0d847
Compare
Co-Authored-By: Leonardo Di Donato <leodidonato@gmail.com> Co-Authored-By: Lorenzo Fontana <lo@linux.com> Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
Needed by statically linked build of Falco. Co-Authored-By: Leonardo Di Donato <leodidonato@gmail.com> Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
leogr
force-pushed
the
fix/integration-test
branch
from
eb0d847
to
54bf0cd
Compare
|
/hold cancel |
leodido
approved these changes
Oct 13, 2020
|
LGTM label has been added. Git tree hash: 4004a6e7bd00b4568c49cea15389364449115f22
|
fntlnz
approved these changes
Oct 13, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fntlnz, leodido The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Leonardo Grasso me@leonardograsso.com
What type of PR is this?
/kind bug
/kind failing-test
Any specific area of the project related to this PR?
/area tests
What this PR does / why we need it:
I and @leodido noticed that the CI is reporting green tests even though some of the integrations tests are not passing.
That happened because the falco-tester entrypoint's script was not returning the exit code of
run_regression_tests.shPlease note that this PR aims just to correct the test suite behavior, not the problems in Falco.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Atm integration tests cannot pass anyways because of the problem explained in #1438 and another problem introduced by #1436. Both problems will be fixed by #1412
Once #1412 gets merged, then we can rebase this PR on top and definitively fix the aforementioned problems.
PS
I needed to push the
falcosecuity/falco-tester:latestdocker image for testing.Does this PR introduce a user-facing change?: