further improvements outputs impl. #1443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
leogr
force-pushed
the
chore/improve-outputs
branch
from
9c64273
to
f6c7deb
Compare
On previously modified files. Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
leogr
changed the title
fntlnz
previously approved these changes
Oct 15, 2020
|
LGTM label has been added. Git tree hash: 8d803a0bafd2d8373a6bfd163838c26348edbd96
|
|
/milestone 0.27.0 |
Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
…lco_common Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
fntlnz
approved these changes
Oct 20, 2020
|
LGTM label has been added. Git tree hash: f189958bf82439ceb4ffb6d16beb54dda0948ce5
|
|
Put this temporarily on |
|
/hold cancel |
leodido
approved these changes
Oct 26, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fntlnz, leodido The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
Any specific area of the project related to this PR?
/area engine
What this PR does / why we need it:
This PR follows up #1412 and is preparatory for a future PR (I will make it later) that implements non-blocking outputs (as per #1417).
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
I decided to include those small changes inside a separate PR (this one) to facilitate the reviewing process.
/cc @leodido
/cc @fntlnz
Does this PR introduce a user-facing change?: