Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-use spawned_process macro inside container_started macro #1449

Merged
merged 1 commit into from
Oct 26, 2020

Conversation

leodido
Copy link
Member

@leodido leodido commented Oct 18, 2020

Signed-off-by: Leonardo Di Donato leodidonato@gmail.com

What type of PR is this?

/kind rule-update

Any specific area of the project related to this PR?

/area rules

What this PR does / why we need it:

Which issue(s) this PR fixes:

NONE

Special notes for your reviewer:

Just a bit of re-use. ♻️

Does this PR introduce a user-facing change?:

rules(macro container_started): re-use `spawned_process` macro inside `container_started` macro

…_started` macro

Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
@poiana
Copy link

poiana commented Oct 19, 2020

LGTM label has been added.

Git tree hash: 839bddf738c3de68c78160d5fd3581c6483e87bd

@poiana
Copy link

poiana commented Oct 19, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fntlnz, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@leogr leogr added this to the 0.27.0 milestone Oct 21, 2020
@poiana poiana merged commit bc9a2f3 into master Oct 26, 2020
@poiana poiana deleted the update/reuse-spawnedprocess-macro-containerstarted branch October 26, 2020 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants