fix(userspace/falco): use given priority in falco_outputs::handle_msg()

[leogr]

What type of PR is this?

/kind bug

/kind cleanup

Any specific area of the project related to this PR?

/area engine

What this PR does / why we need it:

Hardcoded values (Critical) for message's priority were present in falco_outputs::handle_msg():

falco/userspace/falco/falco_outputs.cpp

Line 206 in 47fa7d5

jmsg["priority"] = "Critical";

falco/userspace/falco/falco_outputs.cpp

Line 219 in 47fa7d5

full_msg = timestr + ": " + falco_common::priority_names[LOG_CRIT] + " " + msg + " (";

Although that was no problem because handle_msg() is being used only for drop alerts that are always emitted with Critical priority level, it can lead to errors in the future.

Moreover, handle_msg() has a priority field already in its signature and syscall_evt_drop_mgr is already passing the expected value:

falco/userspace/falco/event_drops.cpp

Lines 138 to 144 in 47fa7d5

	case ACT_ALERT:
	m_outputs->handle_msg(now,
	falco_outputs::PRIORITY_CRITICAL,
	msg,
	rule,
	output_fields);
	break;

So, this PR corrects the handle_msg() implementation to use the given priority.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Since handle_msg() is only called within syscall_evt_drop_mgr and the outputted priority value is not changed, this PR does not introduce any user-facing change.

Somehow related to #1417

Does this PR introduce a user-facing change?:

fix(userspace/falco): use given priority in falco_outputs::handle_msg()

[leogr]

/milestone 0.27.0

[poiana]

LGTM label has been added.

Git tree hash: e293710c96ef89fd7e7214efb47db390ad51dc56

[poiana]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fntlnz, leodido

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [fntlnz,leodido]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment