Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rule(macro multipath_writing_conf): create and use the macro #1475

Merged
merged 1 commit into from
Nov 6, 2020
Merged

rule(macro multipath_writing_conf): create and use the macro #1475

merged 1 commit into from
Nov 6, 2020

Conversation

nmarier-coveo
Copy link
Contributor

What type of PR is this?

/kind rule-update

Any specific area of the project related to this PR?

/area rules

What this PR does / why we need it:

multipath, which is run by systemd-udevd (in our environment), writes to /etc/multipath/wwids, /etc/multipath/bindings and a few other paths under /etc/multipath as part of its normal operation. Falco is sending alerts for this, but given that it's expected behaviour for multipath, it probably shouldn't!

For more information about multipath defaults, see https://manpages.debian.org/testing/multipath-tools/multipath.conf.5.en.html

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?:

rule(macro multipath_writing_conf): create and use the macro

`multipath`, which is run by `systemd-udevd`, writes to
`/etc/multipath/wwids`, `/etc/multipath/bindings` and a few other paths
under `/etc/multipath` as part of its normal operation.

Signed-off-by: Nicolas Marier <nmarier@coveo.com>
@poiana
Copy link

poiana commented Nov 5, 2020

Welcome @nmarier-coveo! It looks like this is your first PR to falcosecurity/falco 🎉

@poiana poiana added the size/XS label Nov 5, 2020
@nmarier-coveo
Copy link
Contributor Author

Welcome @nmarier-coveo! It looks like this is your first PR to falcosecurity/falco tada

For the record, it isn't! I'm just using my work account now instead of @marier-nico 😄

@leogr
Copy link
Member

leogr commented Nov 5, 2020

/cc @Kaizhe

@poiana poiana requested a review from Kaizhe November 5, 2020 16:51
Copy link
Contributor

@Kaizhe Kaizhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@poiana
Copy link

poiana commented Nov 6, 2020

LGTM label has been added.

Git tree hash: fc103d187e91b99715d723c30e8f89a380ab68f2

@poiana poiana added the approved label Nov 6, 2020
@poiana
Copy link

poiana commented Nov 6, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fntlnz, Kaizhe, leodido

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit c055f02 into falcosecurity:master Nov 6, 2020
@poiana
Copy link

poiana commented Nov 6, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fntlnz, Kaizhe, leodido

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@leodido
Copy link
Member

leodido commented Nov 6, 2020

/milestone 0.27.0

@poiana poiana added this to the 0.27.0 milestone Nov 6, 2020
@marier-nico marier-nico deleted the systemd-udevd-write-etc branch November 6, 2020 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants