chore(cmake/modules): avoid useless rebuild #1495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leodido
reviewed
Nov 27, 2020
deepskyblue86
force-pushed
the
master
branch
from
ca232cd
to
0044a0a
Compare
Because of https://gitlab.kitware.com/cmake/cmake/-/issues/16419, every time one compiles, some external projects gets updated causing rebuild. Have EP_UPDATE_DISCONNECTED option (default OFF) to be able to control that behaviour. Signed-off-by: Angelo Puglisi <angelopuglisi86@gmail.com> Co-authored-by: Leonardo Di Donato <leodidonato@gmail.com> Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
|
@leodido since |
Now it passed. CMake version maybe? I guess it's fine like that anyway. |
fntlnz
reviewed
Dec 10, 2020
fntlnz
approved these changes
Dec 10, 2020
|
LGTM label has been added. Git tree hash: 577f416fb8bb254074d9b7a079c2a557b8411c9d
|
leogr
approved these changes
Dec 10, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fntlnz, leogr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/milestone 0.27.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of https://gitlab.kitware.com/cmake/cmake/-/issues/16419, every
time one compiles, some external projects gets updated causing rebuild.
Set UPDATE_DISCONNECTED on EXTERNALPROJECT_ADD, since we can assume git
tags we're using will not change.
Signed-off-by: deepskyblue86 angelopuglisi86@gmail.com
What type of PR is this?
/kind cleanup
Any specific area of the project related to this PR?
cmake
/area build
What this PR does / why we need it:
Avoid unnecessary rebuild
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
No