Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rule(Container Run as Root User): new rule created #1500

Merged
merged 2 commits into from
Dec 4, 2020

Conversation

Kaizhe
Copy link
Contributor

@Kaizhe Kaizhe commented Dec 2, 2020

Signed-off-by: kaizhe derek0405@gmail.com

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

If contributing rules or changes to rules, please make sure to also uncomment one of the following line:

/kind rule-update

/kind rule-create

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area engine

/area rules

/area tests

/area proposals

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #
N/A

Special notes for your reviewer:
The rule is disabled by default as it is still common to run container with root user.

Does this PR introduce a user-facing change?:

rule(Container Run as Root User): new rule created

Signed-off-by: kaizhe <derek0405@gmail.com>
Signed-off-by: kaizhe <derek0405@gmail.com>
@poiana
Copy link

poiana commented Dec 4, 2020

LGTM label has been added.

Git tree hash: aec0cb5313efe0e8602afafa22413b227b18b22d

@poiana poiana added the approved label Dec 4, 2020
Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/milestone 0.27.0

👍

@poiana poiana added this to the 0.27.0 milestone Dec 4, 2020
@poiana
Copy link

poiana commented Dec 4, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leodido, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 0a901e4 into master Dec 4, 2020
@poiana poiana deleted the kh_rule_container-run-as-root branch December 4, 2020 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants