Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix various typos in markdown files. #1514

Merged
merged 1 commit into from
Jan 19, 2021
Merged

Fix various typos in markdown files. #1514

merged 1 commit into from
Jan 19, 2021

Conversation

didier-durand
Copy link
Contributor

Hi there,

As per title, just fixing typos in various .md files.

Didier

Signed-off-by: Didier Durand durand.didier@gmail.com

/kind documentation

What this PR does / why we need it:

Just some language cleanup

Special notes for your reviewer:

Does this PR introduce a user-facing change?:
NO

NONE

@poiana
Copy link

poiana commented Dec 30, 2020

Welcome @didier-durand! It looks like this is your first PR to falcosecurity/falco 🎉

@poiana poiana added the size/S label Dec 30, 2020
@didier-durand
Copy link
Contributor Author

/assign @leodido

leogr
leogr previously approved these changes Jan 8, 2021
Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@poiana poiana added the lgtm label Jan 8, 2021
@poiana
Copy link

poiana commented Jan 8, 2021

LGTM label has been added.

Git tree hash: 3c9f404688175c2709767b2a93857e5779e287b0

@poiana poiana added the approved label Jan 8, 2021
@didier-durand
Copy link
Contributor Author

@leogr: it is my pleasure to contribute. Didier

@leodido
Copy link
Member

leodido commented Jan 18, 2021

/milestone 0.28.0

@poiana poiana added this to the 0.28.0 milestone Jan 18, 2021
leodido
leodido previously approved these changes Jan 18, 2021
Copy link
Member

@leodido leodido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Didier 🤗

These fixes will go in the next release

@leodido
Copy link
Member

leodido commented Jan 18, 2021

/hold

@didier-durand
Copy link
Contributor Author

@leodido : my pleasure to contribute! Didier

Signed-off-by: Didier Durand <durand.didier@gmail.com>
leogr added a commit to falcosecurity/.github that referenced this pull request Jan 19, 2021
Co-Authored-By: Didier Durand <durand.didier@gmail.com>

The correction was originally proposed in  falcosecurity/falco#1514 by Didier Durand

Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
@leogr leogr dismissed stale reviews from leodido and themself via 3d8a6c4 January 19, 2021 14:29
@poiana poiana added size/XS and removed size/S labels Jan 19, 2021
Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @didier-durand

I have rebased the PR for you and ported the GOVERNANCE.md correction to falcosecurity/.github#26 (since the file had been moved).

Ofc, approved again. Thank you! 👍

@poiana poiana added the lgtm label Jan 19, 2021
@poiana
Copy link

poiana commented Jan 19, 2021

LGTM label has been added.

Git tree hash: b34392c4b919ba4729fe5785f099c75d9ef1b08c

@leogr
Copy link
Member

leogr commented Jan 19, 2021

/hold cancel

poiana pushed a commit to falcosecurity/.github that referenced this pull request Jan 19, 2021
Co-Authored-By: Didier Durand <durand.didier@gmail.com>

The correction was originally proposed in  falcosecurity/falco#1514 by Didier Durand

Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
@poiana
Copy link

poiana commented Jan 19, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fntlnz, leodido, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [fntlnz,leodido,leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit b76420f into falcosecurity:master Jan 19, 2021
leogr added a commit to falcosecurity/evolution that referenced this pull request Aug 1, 2022
Co-Authored-By: Didier Durand <durand.didier@gmail.com>

The correction was originally proposed in  falcosecurity/falco#1514 by Didier Durand

Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
leogr added a commit to falcosecurity/evolution that referenced this pull request Aug 2, 2022
Co-Authored-By: Didier Durand <durand.didier@gmail.com>

The correction was originally proposed in  falcosecurity/falco#1514 by Didier Durand

Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
poiana pushed a commit to falcosecurity/evolution that referenced this pull request Aug 28, 2022
Co-Authored-By: Didier Durand <durand.didier@gmail.com>

The correction was originally proposed in  falcosecurity/falco#1514 by Didier Durand

Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
maxgio92 pushed a commit to falcosecurity/evolution that referenced this pull request Sep 8, 2022
Co-Authored-By: Didier Durand <durand.didier@gmail.com>

The correction was originally proposed in  falcosecurity/falco#1514 by Didier Durand

Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
maxgio92 pushed a commit to falcosecurity/evolution that referenced this pull request Sep 22, 2022
Co-Authored-By: Didier Durand <durand.didier@gmail.com>

The correction was originally proposed in  falcosecurity/falco#1514 by Didier Durand

Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants