Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(.circleci): adding Jonah to Falco CI maintainers #1518

Merged
merged 1 commit into from
Jan 13, 2021

Conversation

leodido
Copy link
Member

@leodido leodido commented Jan 11, 2021

Signed-off-by: Leonardo Di Donato leodidonato@gmail.com

What type of PR is this?

/kind documentation

Any specific area of the project related to this PR?

NONE

What this PR does / why we need it:

@jonahjon is already a top contributor to the test-infra repository.

In the past months, he put a lot of effort into helping us to create a better Falco Infrastructure.
Among other things, in December, I and @jonahjon paired also to publish the main Falco container image (falcosecurity/falco) on the AWS ECR gallery (see PR 1512).

Now, he wants to do the same for the other Falco container images (eg., no-driver, ...).
Also, he wants to help to move some CI jobs Falco needs to ProwJobs, and/or to create new ones (eg., aarch64 Falco build).

Which issue(s) this PR fixes:

NONE

Special notes for your reviewer:

Note that the OWNERS file merges hierarchically.
This means that the top-level maintainers do not lose maintainership of the CI adding a OWNERS containing @jonahjon here.

Does this PR introduce a user-facing change?:

docs(.circleci): welcome Jonah (Amazon) as a new Falco CI maintainer

Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
@leodido
Copy link
Member Author

leodido commented Jan 11, 2021

/milestone 0.27.0

@poiana poiana added this to the 0.27.0 milestone Jan 11, 2021
Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @jonahjon !

🥳

@poiana
Copy link

poiana commented Jan 12, 2021

LGTM label has been added.

Git tree hash: a795851420d1bc695441fc1b81ea4f4c40e7a663

@poiana
Copy link

poiana commented Jan 13, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fntlnz, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 0d7068b into master Jan 13, 2021
@poiana poiana deleted the jonah-ci-maintainers branch January 13, 2021 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants