-
Notifications
You must be signed in to change notification settings - Fork 886
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding other alternate AWS builds to circleCI #1519
Conversation
Signed-off-by: jonahjon <jonahjones094@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did an initial review and suggested a fix that I'll apply.
It's late now, I'll continue tomorrow...
/hold
… bin[-dev] bucket Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
Change looks good! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left another comment Jonah
Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
…:latest, falco:<tag>-slim, and falco:latest-slim And publish them too. Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The falco-driver-loader
image requires a FALCO_IMAGE_TAG
build argument.
…CO_IMAGE_TAG build arg (release to AWS ECR gallery) Signed-off-by: Leonardo Di Donato
…mage from master to AWS ECR gallery Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now :)
Thanks for approaching this Jonah, your help is important to us!
LGTM label has been added. Git tree hash: d61530f5449d97407b2005c3a2cdcfef6d19c027
|
Signed-off-by: jonahjon <jonahjones094@gmail.com>
Of course, actually getting this all fixed up finally here too |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM,
Thank you, @jonahjon
LGTM label has been added. Git tree hash: f8c05e7e840048f7c532c787fa34f04c18396ac7
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: leodido, leogr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
Signed-off-by: jonahjon jonahjones094@gmail.com
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area build
What this PR does / why we need it:
Uploads other Falco images
no-driver
anddriver-loader
to AWS public gallery.Does this PR introduce a user-facing change?:
No