Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding other alternate AWS builds to circleCI #1519

Merged
merged 7 commits into from
Mar 5, 2021

Conversation

jonahjon
Copy link
Contributor

@jonahjon jonahjon commented Jan 11, 2021

Signed-off-by: jonahjon jonahjones094@gmail.com

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

What this PR does / why we need it:

Uploads other Falco images no-driver and driver-loader to AWS public gallery.

Does this PR introduce a user-facing change?:

No

new: falco-no-driver container images on AWS ECR gallery (https://gallery.ecr.aws/falcosecurity/falco-no-driver)
new: falco-driver-loader container images on AWS ECR gallery (https://gallery.ecr.aws/falcosecurity/falco-driver-loader)

Signed-off-by: jonahjon <jonahjones094@gmail.com>
Copy link
Member

@leodido leodido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did an initial review and suggested a fix that I'll apply.

It's late now, I'll continue tomorrow...

/hold

.circleci/config.yml Outdated Show resolved Hide resolved
… bin[-dev] bucket


Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
@jonahjon jonahjon requested a review from leodido January 14, 2021 17:35
@jonahjon
Copy link
Contributor Author

Change looks good!

Copy link
Member

@leodido leodido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left another comment Jonah

.circleci/config.yml Outdated Show resolved Hide resolved
.circleci/config.yml Show resolved Hide resolved
Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
.circleci/config.yml Show resolved Hide resolved
.circleci/config.yml Show resolved Hide resolved
.circleci/config.yml Show resolved Hide resolved
…:latest, falco:<tag>-slim, and falco:latest-slim


And publish them too.

Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
Copy link
Member

@leodido leodido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The falco-driver-loader image requires a FALCO_IMAGE_TAG build argument.

.circleci/config.yml Outdated Show resolved Hide resolved
.circleci/config.yml Outdated Show resolved Hide resolved
…CO_IMAGE_TAG build arg (release to AWS ECR gallery)


Signed-off-by: Leonardo Di Donato
.circleci/config.yml Outdated Show resolved Hide resolved
.circleci/config.yml Outdated Show resolved Hide resolved
.circleci/config.yml Outdated Show resolved Hide resolved
.circleci/config.yml Outdated Show resolved Hide resolved
…mage from master to AWS ECR gallery


Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
leodido
leodido previously approved these changes Jan 15, 2021
Copy link
Member

@leodido leodido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now :)

Thanks for approaching this Jonah, your help is important to us!

@poiana
Copy link

poiana commented Jan 15, 2021

LGTM label has been added.

Git tree hash: d61530f5449d97407b2005c3a2cdcfef6d19c027

Signed-off-by: jonahjon <jonahjones094@gmail.com>
@jonahjon
Copy link
Contributor Author

LGTM now :)

Thanks for approaching this Jonah, your help is important to us!

Of course, actually getting this all fixed up finally here too

Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,

Thank you, @jonahjon

@poiana
Copy link

poiana commented Jan 15, 2021

LGTM label has been added.

Git tree hash: f8c05e7e840048f7c532c787fa34f04c18396ac7

@fntlnz fntlnz added this to the 0.28.0 milestone Jan 17, 2021
@poiana
Copy link

poiana commented Feb 8, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leodido, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@leogr
Copy link
Member

leogr commented Mar 5, 2021

/hold cancel

@poiana poiana merged commit 96ad761 into falcosecurity:master Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants