Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cmake): remove unnecessary whitespace patch #1522

Merged
merged 1 commit into from
Jan 15, 2021

Conversation

leogr
Copy link
Member

@leogr leogr commented Jan 13, 2021

What type of PR is this?

/kind cleanup

Any specific area of the project related to this PR?

/area build

What this PR does / why we need it:

Very small improvement required to reduce the likelihood that the patching process will fail when the upstream file gets modified.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Not a big issue right now, but may be useful in development since the patching process is already failing if using the latest commit from sysdig. I stumbled upon this problem while experimenting.

/cc @leodido

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
Comment on lines -45 to -48
- if(udig_alloc_ring_descriptors(&(handle->m_devs[0].m_bufinfo_fd),
- &handle->m_devs[0].m_bufinfo,
+ if(udig_alloc_ring_descriptors(&(handle->m_devs[0].m_bufinfo_fd),
+ &handle->m_devs[0].m_bufinfo,
Copy link
Member Author

@leogr leogr Jan 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

N.B.:
this hunk ☝️ was just removing a trailing white space at ...&handle->m_devs[0].m_bufinfo, . Not actually needed.

@poiana
Copy link

poiana commented Jan 13, 2021

LGTM label has been added.

Git tree hash: 152678348027cc94aca865bd54afaf2b97f22b4a

@leogr leogr changed the title wip: chore(cmake): remove unnecessary whitespace patch chore(cmake): remove unnecessary whitespace patch Jan 14, 2021
@leogr leogr requested a review from fntlnz January 14, 2021 17:00
@poiana
Copy link

poiana commented Jan 15, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fntlnz, leodido

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@poiana
Copy link

poiana commented Jan 15, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fntlnz, leodido

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fntlnz
Copy link
Contributor

fntlnz commented Jan 15, 2021

/milestone 0.27.0

@poiana poiana added this to the 0.27.0 milestone Jan 15, 2021
@poiana poiana merged commit b2bbb26 into master Jan 15, 2021
@poiana poiana deleted the chore/patch-whitespace branch January 15, 2021 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants