add eks:node-manager to allowed_k8s_users list #1536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Welcome @ismailyenigul! It looks like this is your first PR to falcosecurity/falco 🎉 |
|
Thank you for opening this PR! Anyway, before we can look into it, we need that all commits to be signed-off (you can find more detail here). Let me know if you need any help. |
eks:node-manager is an Amazon EKS internal service role that performs specific operations for managed node groups and Fargate. Reference: https://github.com/awsdocs/amazon-eks-user-guide/blob/master/doc_source/logging-monitoring.md Related falco log ``` {"output":"10:56:31.181308928: Warning K8s Operation performed by user not in allowed list of users (user=eks:node-manager target=aws-auth/configmaps verb=get uri=/api/v1/namespaces/kube-system/configmaps/aws-auth?timeout=19s resp=200)","priority":"Warning","rule":"Disallowed K8s User","time":"2021-01-26T10:56:31.181308928Z", "output_fields": {"jevt.time":"10:56:31.181308928","ka.response.code":"200","ka.target.name":"aws-auth","ka.target.resource":"configmaps","ka.uri":"/api/v1/namespaces/kube-system/configmaps/aws-auth?timeout=19s","ka.user.name":"eks:node-manager","ka.verb":"get"}} ``` Signed-off-by: ismailyenigul <ismailyenigul@gmail.com>
poiana
added
do-not-merge/contains-merge-commits
dco-signoff: yes
and removed
dco-signoff: no
do-not-merge/contains-merge-commits
labels
|
LGTM label has been added. Git tree hash: f36014e6e48a9cd399a1bd192e012f0614e4b8d4
|
|
@ismailyenigul thank you for your contribution! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Kaizhe, leogr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
eks:node-manager is an Amazon EKS internal service role that performs specific operations for managed node groups and Fargate.
Reference: https://github.com/awsdocs/amazon-eks-user-guide/blob/master/doc_source/logging-monitoring.md
Related falco log
What type of PR is this?
kind feature
kind rule-update
Any specific area of the project related to this PR?
area rules
What this PR does / why we need it:
it adds eks:node-manager to allowed_k8s_users list
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: