Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken links to docs. #1563

Merged
merged 1 commit into from
Mar 5, 2021
Merged

Fix broken links to docs. #1563

merged 1 commit into from
Mar 5, 2021

Conversation

shane-lawrence
Copy link
Contributor

@shane-lawrence shane-lawrence commented Feb 22, 2021

Signed-off-by: Shane Lawrence shane@lawrence.dev

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

If contributing rules or changes to rules, please make sure to also uncomment one of the following line:

/kind rule-update

/kind rule-create

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area engine

/area rules

/area tests

/area proposals

What this PR does / why we need it:

This PR fixes broken links in the regression tests' README. The path to these pages in the official Falco docs changed slightly.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

docs(test): update links to new Falco website URLs

Signed-off-by: Shane Lawrence <shane@lawrence.dev>
@poiana
Copy link

poiana commented Feb 22, 2021

@shane-lawrence: The label(s) area/tests cannot be applied, because the repository doesn't have them

In response to this:

Signed-off-by: Shane Lawrence shane@lawrence.dev

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

If contributing rules or changes to rules, please make sure to also uncomment one of the following line:

/kind rule-update

/kind rule-create

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area engine

/area rules

/area tests

/area proposals

What this PR does / why we need it:

This PR fixes broken links in the regression tests' README. The path to these pages in the official Falco docs changed slightly.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thank you!

/milestone 0.28.0

@poiana poiana added this to the 0.28.0 milestone Feb 22, 2021
@poiana poiana added the lgtm label Feb 22, 2021
@poiana
Copy link

poiana commented Feb 22, 2021

LGTM label has been added.

Git tree hash: f1ad2fcf7c3a86fae1786c34b973ba4b38d1b351

@poiana
Copy link

poiana commented Mar 4, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leodido, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit da8f054 into falcosecurity:master Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants