Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kh add rule for container escape #1583

Merged
merged 2 commits into from
Mar 22, 2021
Merged

Conversation

Kaizhe
Copy link
Contributor

@Kaizhe Kaizhe commented Mar 21, 2021

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

If contributing rules or changes to rules, please make sure to also uncomment one of the following line:

/kind rule-update

/kind rule-create

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area engine

/area rules

/area tests

/area proposals

What this PR does / why we need it:

  1. Add rules Debugfs Launched in Privileged Container and Mount Launched in Privileged Container to detect container escape activities inside privileged containers.
  2. Add k3s-agent in the whitelist in rule Set Setuid or Setgid bit to reduce FP.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

https://man7.org/linux/man-pages/man8/mount.8.html

https://man7.org/linux/man-pages/man8/debugfs.8.html

Does this PR introduce a user-facing change?:

rule(Debugfs Launched in Privileged Container): new rule
rule(Mount Launched in Privileged Container): new rule
rule(Set Setuid or Setgid bit): add k3s-agent in the whitelist

…Privileged Container): create

Signed-off-by: Kaizhe Huang <derek0405@gmail.com>
Signed-off-by: Kaizhe Huang <derek0405@gmail.com>
Copy link
Member

@leodido leodido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@poiana
Copy link

poiana commented Mar 22, 2021

LGTM label has been added.

Git tree hash: e0fa5bf49bf9b0f9bd3e28934ad8debd6559bea8

Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

/milestone 0.28.0

@poiana poiana added this to the 0.28.0 milestone Mar 22, 2021
@poiana
Copy link

poiana commented Mar 22, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leodido, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 7ea80e3 into master Mar 22, 2021
@poiana poiana deleted the kh-add_rule_for_container_escape branch March 22, 2021 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants