Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update rule description #1588

Merged
merged 1 commit into from
Mar 24, 2021
Merged

fix: update rule description #1588

merged 1 commit into from
Mar 24, 2021

Conversation

0xff-dev
Copy link
Contributor

@0xff-dev 0xff-dev commented Mar 23, 2021

Signed-off-by: stevenshuang stevenshuang521@gmail.com
What type of PR is this?

/kind bug
/kind rule-update

Any specific area of the project related to this PR?

/area rules

What this PR does / why we need it:
fix rule description.
Which issue(s) this PR fixes:

rule(Write below monitored dir): improve rule description

Signed-off-by: stevenshuang <stevenshuang521@gmail.com>
@poiana
Copy link

poiana commented Mar 23, 2021

Welcome @stevenshuang! It looks like this is your first PR to falcosecurity/falco 🎉

Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@poiana
Copy link

poiana commented Mar 23, 2021

LGTM label has been added.

Git tree hash: 15c53d1bef64e91f7198740bd3a2804e8ef7aeb6

@leogr
Copy link
Member

leogr commented Mar 23, 2021

/milestone 0.28.0

@poiana poiana added this to the 0.28.0 milestone Mar 23, 2021
@0xff-dev
Copy link
Contributor Author

/assign @Kaizhe

Copy link
Contributor

@Kaizhe Kaizhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@poiana
Copy link

poiana commented Mar 24, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Kaizhe, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 167c5bc into falcosecurity:master Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants