Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update: fixtures URLs #1603

Merged
merged 2 commits into from
Apr 8, 2021
Merged

update: fixtures URLs #1603

merged 2 commits into from
Apr 8, 2021

Conversation

leogr
Copy link
Member

@leogr leogr commented Apr 7, 2021

What type of PR is this?

/kind cleanup

Any specific area of the project related to this PR?

/area tests

What this PR does / why we need it:

This PR updates the download URLs of trace files that are used in the test suites.
It also allows specifying a different base URL in case one wants to use different files for development purposes.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:
/milestone 0.28.0

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
@poiana
Copy link

poiana commented Apr 7, 2021

LGTM label has been added.

Git tree hash: 5eda53a45ca6e8bebcb36c29ea624a91c16c7da0

@poiana poiana added the approved label Apr 7, 2021
@poiana
Copy link

poiana commented Apr 8, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fntlnz, leodido

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 3637837 into master Apr 8, 2021
@poiana poiana deleted the update/fixtures-urls branch April 8, 2021 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants