Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(test): express that grpcurl and virtualenv are needed #1609

Merged
merged 1 commit into from
Apr 8, 2021

Conversation

fntlnz
Copy link
Contributor

@fntlnz fntlnz commented Apr 8, 2021

Signed-off-by: Lorenzo Fontana lo@linux.com

What type of PR is this?

/kind documentation

Any specific area of the project related to this PR?

/area tests

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

docs(test): document the prerequisites for running the integration test suite locally

Signed-off-by: Lorenzo Fontana <lo@linux.com>
@poiana poiana added the lgtm label Apr 8, 2021
@poiana
Copy link

poiana commented Apr 8, 2021

LGTM label has been added.

Git tree hash: ad9ddcfd9841c470267025ca7c10719de7651e22

@poiana poiana added the approved label Apr 8, 2021
@poiana
Copy link

poiana commented Apr 8, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leodido, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@leodido
Copy link
Member

leodido commented Apr 8, 2021

/milestone 0.28.0

@poiana poiana added this to the 0.28.0 milestone Apr 8, 2021
@poiana poiana merged commit cdeafa6 into master Apr 8, 2021
@poiana poiana deleted the docs/tests-deps branch April 8, 2021 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants