Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated OCI image repositories in default ruleset #1634

Merged
merged 1 commit into from
Apr 29, 2021
Merged

Remove deprecated OCI image repositories in default ruleset #1634

merged 1 commit into from
Apr 29, 2021

Conversation

maxgio92
Copy link
Member

@maxgio92 maxgio92 commented Apr 28, 2021

What type of PR is this?

/kind cleanup
/kind rule-update

Any specific area of the project related to this PR?

/area rules

What this PR does / why we need it:

Cleans up no longer valid references.

Which issue(s) this PR fixes:

Fixes #1633

Special notes for your reviewer:

The default Falco ruleset references (mostly to ignore the containers which runs with) OCI image repositories that are no longer available or maintained. One example is docker.io/sysdig/falco, which is replaced by docker.io/falcosecurity/falco.

Does this PR introduce a user-facing change?:

rule(list `falco_privileged_images`): remove deprecated Falco's OCI image repositories
rule(list `falco_sensitive_mount_images`): remove deprecated Falco's OCI image repositories
rule(macro `k8s_containers`): remove deprecated Falco's OCI image repositories

Signed-off-by: maxgio92 <massimiliano.giovagnoli.1992@gmail.com>
@maxgio92 maxgio92 changed the title Remove deprecated oci image repositories in default ruleset Remove deprecated OCI image repositories in default ruleset Apr 28, 2021
@leodido
Copy link
Member

leodido commented Apr 28, 2021

/milestone 0.28.1

@poiana poiana added this to the 0.28.1 milestone Apr 28, 2021
@poiana
Copy link

poiana commented Apr 28, 2021

LGTM label has been added.

Git tree hash: 598e9e2593ccfb6c40afa07855bf6b5765f4046b

@leodido
Copy link
Member

leodido commented Apr 28, 2021

@maxgio92 please populate the release notes :)

Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link

poiana commented Apr 29, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit fd6a1d0 into falcosecurity:master Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cleanup referenced old OCI image repositories in default ruleset
4 participants