Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(proposals): fix libs contribution name #1641

Merged
merged 1 commit into from
May 17, 2021

Conversation

leodido
Copy link
Member

@leodido leodido commented May 6, 2021

Signed-off-by: Leonardo Di Donato leodidonato@gmail.com

What type of PR is this?

/kind cleanup

/kind documentation

Any specific area of the project related to this PR?

/area proposals

What this PR does / why we need it:

I noticed the libs contribution file name contained a wrong date, this PR fixes it.

Which issue(s) this PR fixes:

NONE

Special notes for your reviewer:

I'm about to submit a PR to update the link in the Falco blog as soon this gets merged in.

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
@poiana poiana added the lgtm label May 6, 2021
@poiana
Copy link

poiana commented May 6, 2021

LGTM label has been added.

Git tree hash: c22c0ed0becfaf310f3c3099f1418fb3d43a7e2f

@leogr leogr modified the milestone: 0.29.0 May 7, 2021
@leogr leogr modified the milestones: 0.29.0, 0.28.2 May 17, 2021
@leogr
Copy link
Member

leogr commented May 17, 2021

/approve

@poiana
Copy link

poiana commented May 17, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 24f64ca into master May 17, 2021
@poiana poiana deleted the chore/fix-libscontrib-proposal-name branch May 17, 2021 14:24
@leogr leogr modified the milestones: 0.28.2, 0.29.0 Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants