Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rule update(Non sudo setuid): check user id as well in case user name… #1665

Merged
merged 1 commit into from
Jun 10, 2021

Conversation

Kaizhe
Copy link
Contributor

@Kaizhe Kaizhe commented Jun 4, 2021

… info is not available

Signed-off-by: Kaizhe Huang khuang@aurora.tech

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

If contributing rules or changes to rules, please make sure to also uncomment one of the following line:

/kind rule-update

/kind rule-create

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area engine

/area rules

/area tests

/area proposals

What this PR does / why we need it:

Fix false positive

Which issue(s) this PR fixes:

#1664

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

rule(Non sudo setuid): check user id as well in case user name info is not available

… info is not available

Signed-off-by: Kaizhe Huang <khuang@aurora.tech>
@poiana poiana requested review from mfdii and mstemm June 4, 2021 05:20
@Kaizhe Kaizhe requested review from leogr and removed request for mfdii June 4, 2021 05:20
@poiana poiana added the size/XS label Jun 4, 2021
Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

/milestone 0.29.0

@poiana poiana added this to the 0.29.0 milestone Jun 4, 2021
@poiana poiana added the lgtm label Jun 4, 2021
@poiana
Copy link

poiana commented Jun 4, 2021

LGTM label has been added.

Git tree hash: f44e2675f4b1f0afd8e6b6b9b6a37b4c06d1a1b0

@Kaizhe Kaizhe requested review from leodido and removed request for mstemm June 5, 2021 03:56
@leodido
Copy link
Member

leodido commented Jun 10, 2021

/approve

@poiana
Copy link

poiana commented Jun 10, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Kaizhe, leodido

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit b268d4d into master Jun 10, 2021
@poiana poiana deleted the kh_fix-1664 branch June 10, 2021 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants