Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rules(list miner_domains): add rx.unmineable.com for anti-miner detection #1676

Merged
merged 1 commit into from
Jun 17, 2021

Conversation

fntlnz
Copy link
Contributor

@fntlnz fntlnz commented Jun 16, 2021

Signed-off-by: Lorenzo Fontana lo@linux.com

What type of PR is this?

/kind rule-update

Any specific area of the project related to this PR?

/area rules

What this PR does / why we need it:

Noticed that this miners pool was not included in our detection. Added it

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

rule(list miner_domains): add rx.unmineable.com for anti-miner detection

…tion

Signed-off-by: Lorenzo Fontana <lo@linux.com>
Copy link
Member

@leodido leodido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@leodido
Copy link
Member

leodido commented Jun 16, 2021

/milestone 0.29.0

@poiana poiana added this to the 0.29.0 milestone Jun 16, 2021
Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Thank you!

@poiana
Copy link

poiana commented Jun 17, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fntlnz, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 0f24448 into falcosecurity:master Jun 17, 2021
@fntlnz fntlnz deleted the rules/miner-unmineable branch June 22, 2021 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants