Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix link to CONTRIBUTING.md in the Pull Request Template #1679

Merged
merged 1 commit into from
Jun 21, 2021
Merged

Fix link to CONTRIBUTING.md in the Pull Request Template #1679

merged 1 commit into from
Jun 21, 2021

Conversation

tspearconquest
Copy link
Contributor

@tspearconquest tspearconquest commented Jun 18, 2021

Signed-off-by: Thomas Spear tspear@conquestcyber.com

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

If contributing rules or changes to rules, please make sure to also uncomment one of the following line:

/kind rule-update

/kind rule-create

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area engine

/area rules

/area tests

/area proposals

What this PR does / why we need it:
The link to the contributing guide is a vital one.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: Thomas Spear <tspear@conquestcyber.com>
Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

/milestone 0.30.0

@poiana poiana added this to the 0.30.0 milestone Jun 21, 2021
@poiana poiana added the lgtm label Jun 21, 2021
@poiana
Copy link

poiana commented Jun 21, 2021

LGTM label has been added.

Git tree hash: e93f55d339f5d26220ae4fb1a913614733c0a772

@leodido
Copy link
Member

leodido commented Jun 21, 2021

/approve

@poiana
Copy link

poiana commented Jun 21, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leodido, tspearconquest

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit acd5422 into falcosecurity:master Jun 21, 2021
@leogr
Copy link
Member

leogr commented Jun 21, 2021

/milestone 0.29.0

@poiana poiana modified the milestones: 0.30.0, 0.29.0 Jun 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants