Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(docker): adding libssl-dev, upstream image reference pinned to debian:buster #1719

Merged
merged 1 commit into from Sep 9, 2021

Conversation

michalschott
Copy link
Contributor

@michalschott michalschott commented Sep 1, 2021

What type of PR is this?
/kind bug

Any specific area of the project related to this PR?
/area build

What this PR does / why we need it:
This PR updates base image with libssl-dev package required to compile kernel module.
It also updates upstream container reference, since recently Buster becomes new stable and container refuses to build.

Which issue(s) this PR fixes:

Fixes #1718

Special notes for your reviewer:

Since Debian Bullseye become new stable, it is also required to update base image reference.

Does this PR introduce a user-facing change?:

NONE

@poiana
Copy link

poiana commented Sep 1, 2021

Welcome @michalschott! It looks like this is your first PR to falcosecurity/falco 🎉

@poiana poiana added the size/XS label Sep 1, 2021
Added libssl-dev package.

Signed-off-by: Michal Schott <michal.schott@onegini.com>
@leogr
Copy link
Member

leogr commented Sep 8, 2021

/milestone 0.30.0

@poiana poiana added this to the 0.30.0 milestone Sep 8, 2021
@leogr leogr requested a review from mstemm September 8, 2021 08:56
Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana poiana added the lgtm label Sep 8, 2021
@poiana
Copy link

poiana commented Sep 8, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leogr, michalschott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana
Copy link

poiana commented Sep 8, 2021

LGTM label has been added.

Git tree hash: e77469322f06b9fd45c45e094e10a44a0cf19d64

@poiana poiana added the approved label Sep 8, 2021
@leogr
Copy link
Member

leogr commented Sep 9, 2021

Firstly, thank you for this PR! 👍
Secondly, I forgot to add some thoughts regarding this PR, so here I'm 😺

Pinning debian:buster is ok for me as a temporary solution until we rethink the Dockerfile a bit and make it work with the latest Debian or some other way (as we discussed during yesterday's community call). Moreover, this fix will help with the CI failures we are encountering on the master branch. That is even more important if we consider that the next release is approaching (otherwise we won't be able to release if the container image refused to build).

@poiana poiana merged commit 84e7d3f into falcosecurity:master Sep 9, 2021
@leogr leogr changed the title Adding libssl-dev, fixing upstream image reference. build(docker): adding libssl-dev, upstream image reference pinned to debian:buster Sep 28, 2021
@lichao127 lichao127 mentioned this pull request May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Falco fails to build eBPF module for amazon-linux.
4 participants