Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new miner pools to miner domain lists to improve detection #1729

Merged
merged 3 commits into from
Sep 17, 2021
Merged

Add new miner pools to miner domain lists to improve detection #1729

merged 3 commits into from
Sep 17, 2021

Conversation

AlbertoPellitteri
Copy link
Contributor

Signed-off-by: Alberto Pellitteri albertopellitteri96@gmail.com
Co-authored-by: darryk10 stefano.chierici@sysdig.com

What type of PR is this?

/kind rule-update

Any specific area of the project related to this PR?

/area rules

What this PR does / why we need it:

Found and added some new miner pools that enhance miner detection.

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

rule(list miner_domains): add new miner domains
rule(list https_miner_domains): add new miner domains

Signed-off-by: Alberto Pellitteri <albertopellitteri96@gmail.com>
Co-authored-by: darryk10 <stefano.chierici@sysdig.com>
Signed-off-by: Alberto Pellitteri <albertopellitteri96@gmail.com>
Co-authored-by: darryk10 <stefano.chierici@sysdig.com>
@poiana
Copy link

poiana commented Sep 15, 2021

Welcome @AlbertoPellitteri! It looks like this is your first PR to falcosecurity/falco 🎉

2 similar comments
@poiana
Copy link

poiana commented Sep 15, 2021

Welcome @AlbertoPellitteri! It looks like this is your first PR to falcosecurity/falco 🎉

@poiana
Copy link

poiana commented Sep 15, 2021

Welcome @AlbertoPellitteri! It looks like this is your first PR to falcosecurity/falco 🎉

@poiana poiana added the size/S label Sep 15, 2021
@AlbertoPellitteri
Copy link
Contributor Author

/assign @mstemm

"xmr.crypto-pool.fr"
"xmr.crypto-pool.fr",
"ss.antpool.com",
"stratum-dash.antpool.com.antpool.com",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should stratum-dash.antpool.com.antpool.com be stratum-dash.antpool.com

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Typo fixed.

Co-authored-by: darryk10 <stefano.chierici@sysdig.com>
Signed-off-by: Alberto Pellitteri <albertopellitteri96@gmail.com>
@leogr
Copy link
Member

leogr commented Sep 16, 2021

/milestone 0.30.0

@poiana poiana added this to the 0.30.0 milestone Sep 16, 2021
@poiana
Copy link

poiana commented Sep 16, 2021

LGTM label has been added.

Git tree hash: d042c1e4b368db92491055085b7c16d09100c6b0

Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
/approve

@poiana
Copy link

poiana commented Sep 17, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AlbertoPellitteri, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 8748093 into falcosecurity:master Sep 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants