-
Notifications
You must be signed in to change notification settings - Fork 876
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update(proposal): clarify that old drivers are not removed anymore #1738
Conversation
Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: leodido The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the clarification.
Can you please add more detail about what the expectation is to a user? Will Falco break? If so when should we expect it to break after this change? What will we expect Falco to do if/when it breaks? Does Falco now have a log line that will reference this change that is printed to I do not have any issues with the change, however I do not think this does a good job at explaining what might go wrong after this change takes place. Maybe I am missing this documentation somewhere else? My main concern is that people will be affected by this, and we will see GitHub issues like "Falco unable to find driver on {os} and {kernel}" and it will take one of us a large amount of time to connect these new issues back to this change. We should do what we can to make our end-users as self sufficient as possible, so that they do not need a maintainer to help them understand why Falco stopped working. |
These edits just reflects changes in place for all the past year, Kris. In fact, it is just a documentation change about the fact that we store drivers at https://download.falco.org and we do not need anymore to delete the previous Falco drivers (like we had to do in the past) because we are free from storage limits and constraints. There is nothing that can go wrong since this just updates an almost 2 years old proposal for reflecting the new process that has been in place for 6 releases already. |
Nothing will change. This is just a further clarification of what is already in place.
No, Falco will not break, because nothing is changing here.
This PR clarifies more that we are keeping all previous prebuilts on S3, available for download at https://download.falco.org/. So we should not see that kind of issues :)
That's exactly what we did when decided to do NOT delete drivers from S3 anymore. So, again I just want to ensure you that this PR it's just a documentation change to clarify that we are already going to the right direction :) |
Signed-off-by: Leonardo Di Donato leodidonato@gmail.com
What type of PR is this?
/kind cleanup
Any specific area of the project related to this PR?
/area proposals
What this PR does / why we need it:
Clarify that the
drivers/cleanup
job we needed when we were using Bintray to store the Falco drivers is not needed anymore. And that, its related proposal has been superseded by a newer one (already implemented and in place during the last year).Which issue(s) this PR fixes:
NONE
Special notes for your reviewer:
/milestone 0.30.0
Does this PR introduce a user-facing change?: