Sign Packages and Linux Repositories with SHA256. #1758
Conversation
|
Welcome @twa16! It looks like this is your first PR to falcosecurity/falco 🎉 |
twa16
force-pushed
the
sha256-signatures-for-packages
branch
from
2613bed
to
e8a0bdd
Compare
|
Did CircleCI just fail to return results? |
|
Anything needed from me on this PR? |
|
Closing and re-opening to trigger the CI |
|
@leogr: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/reopen |
|
@leogr: Reopened this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/milestone 0.31.0 |
|
Looks like the one fail here is also on the main branch right now so probably no related to the PR. |
#1764 should address the failing test. Let's wait for it. |
poiana
added
dco-signoff: no
do-not-merge/contains-merge-commits
and removed
dco-signoff: yes
labels
Signed-off-by: Manuel Gauto <mgauto@mgenterprises.org>
twa16
force-pushed
the
sha256-signatures-for-packages
branch
from
b8f5919
to
cd379a4
Compare
|
@leogr Ok, rebased! Let's see how it goes. |
|
Closing and re-opening to trigger the CI |
|
@leogr: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/reopen |
|
@leogr: Reopened this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
LGTM label has been added. Git tree hash: f60f9f0e14164f69cce4a38295aca9a6120c459d
|
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: leogr, twa16 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area build
What this PR does / why we need it:
Currently, Falco Linux packages are signed with SHA1. This prevents the installation of Falco on high-assurance systems that do not allow for the installation of packages without signatures made using SHA256.
Which issue(s) this PR fixes:
Fixes #1751
Special notes for your reviewer:
The SHA256 algorithms should be well supported by Linux distributions in use today. I do not believe this this will break installs for anyone.
Does this PR introduce a user-facing change?:
Linux packages and repositories that are created with the modified build scripts will have newer signature algorithms.