Update k8s rules #1760
Merged
Update k8s rules #1760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sverre Boschman <1142569+sboschman@users.noreply.github.com>
Signed-off-by: Sverre Boschman <1142569+sboschman@users.noreply.github.com>
sboschman
force-pushed
the
update-k8s-rules
branch
from
1dafece
to
5f035ec
Compare
Kaizhe
approved these changes
Oct 26, 2021
|
LGTM label has been added. Git tree hash: 60f93f3eeb8fda0c2bdf099ec1ce60779f64c363
|
leogr
approved these changes
Oct 29, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: leogr, sboschman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
/kind rule-update
Any specific area of the project related to this PR?
/area rules
What this PR does / why we need it:
This PR adds a few more default k8s service accounts to the
known_sa_list(these service accounts belong to default k8s controllers, see docs https://kubernetes.io/docs/reference/command-line-tools-reference/kube-controller-manager/).Not listed in the docs mentioned above are the coredns sa's. As CoreDNS is such an integral part of k8s I opted to list coredns and coredns-autoscaler sa's as well.
To make the sa list easier to view, imo, I formatted it as 1 item per line and ordered all entries alphabetically.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: