Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(userspace/falco): in case output_file cannot be opened, throw a falco exception #1773

Merged
merged 1 commit into from
Dec 9, 2021

Conversation

FedeDP
Copy link
Contributor

@FedeDP FedeDP commented Nov 8, 2021

Signed-off-by: Federico Di Pierro nierro92@gmail.com

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

Any specific area of the project related to this PR?

/area engine

What this PR does / why we need it:

This PR just throws an error if desired output_file failed to be created:

Mon Nov  8 11:00:01 2021: Falco version 0.30.0-19+f7893fb (driver version a03ccfda795f2ba711b80f69cb06869f2b63121b)
Mon Nov  8 11:00:01 2021: Falco initialized with configuration file ../falco.yaml
Mon Nov  8 11:00:01 2021: Loading rules from file ../rules/falco_rules.yaml:
Mon Nov  8 11:00:02 2021: Starting internal webserver, listening on port 8765
Mon Nov  8 11:00:10 2021: file: failed to open output file /home/federicoo/events.txt
11:00:10.602534779: Error File below known binary directory renamed/removed (user=root user_loginuid=1000 command=rm -i /usr/bin/topkek pcmdline=sudo rm -i /usr/bin/topkek operation=unlinkat file=<NA> res=0 dirfd=-100(AT_FDCWD) name=/usr/bin/topkek flags=0  container_id=host image=<NA>)

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

fix(userspace/falco): in case output_file cannot be opened, throw a falco exception

…alco exception.

Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

/approve

@poiana
Copy link

poiana commented Nov 25, 2021

LGTM label has been added.

Git tree hash: c04fd83e400b0489ba34d7b47341ea3feb8cef26

@leogr
Copy link
Member

leogr commented Nov 25, 2021

/milestone 0.31.0

@poiana poiana added this to the 0.31.0 milestone Nov 25, 2021
@poiana
Copy link

poiana commented Nov 25, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 9dcd8bc into falcosecurity:master Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants