Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop Falco luajit module, use the one provied by libs #1788

Merged
merged 4 commits into from
Nov 17, 2021

Conversation

FedeDP
Copy link
Contributor

@FedeDP FedeDP commented Nov 16, 2021

Signed-off-by: Federico Di Pierro <nierro92@gmail.com>

Co-authored-by: Leonardo Grasso <me@leonardograsso.com>
Co-authored-by: Jason Dellaluce <jasondellaluce@gmail.com>

What type of PR is this?

/kind cleanup

Any specific area of the project related to this PR?

/area build

What this PR does / why we need it:

The PR allows Falco to build using luaJIT provided by libs.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@FedeDP
Copy link
Contributor Author

FedeDP commented Nov 17, 2021

We still need to rebase this PR to falco master once #1782 is merged.

FedeDP and others added 4 commits November 17, 2021 16:22
…d by libs (upgraded) instead.

Signed-off-by: Federico Di Pierro <nierro92@gmail.com>

Co-authored-by: Leonardo Grasso <me@leonardograsso.com>
Co-authored-by: Jason Dellaluce <jasondellaluce@gmail.com>
Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
Signed-off-by: Federico Di Pierro <nierro92@gmail.com>

Co-authored-by: Leonardo Grasso <me@leonardograsso.com>
Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
@FedeDP
Copy link
Contributor Author

FedeDP commented Nov 17, 2021

Rebased!

@FedeDP FedeDP changed the title wip: drop Falco luajit module, use the one provied by libs drop Falco luajit module, use the one provied by libs Nov 17, 2021
@leogr
Copy link
Member

leogr commented Nov 17, 2021

/milestone 0.31.0

@poiana poiana added this to the 0.31.0 milestone Nov 17, 2021
Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link

poiana commented Nov 17, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana
Copy link

poiana commented Nov 17, 2021

LGTM label has been added.

Git tree hash: 7ab77e747e5666b6f0b1fe770e3ac169ce50e12e

@poiana poiana merged commit 35302f6 into falcosecurity:master Nov 17, 2021
@FedeDP FedeDP deleted the drop_luajit branch November 17, 2021 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants