Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(userspace/falco): accept 'Content-Type' header that contains "application/json", but it is not strictly equal to it #1800

Merged
merged 2 commits into from
Dec 9, 2021
Merged

fix(userspace/falco): accept 'Content-Type' header that contains "application/json", but it is not strictly equal to it #1800

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a628e36
fix(userspace/falco): accept 'Content-Type' header that contains "app…
FedeDP Nov 19, 2021
66732f3
update(userspace/falco): enforce check that content-type actually sta…
FedeDP Nov 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion userspace/falco/webserver.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,8 @@ bool k8s_audit_handler::handlePost(CivetServer *server, struct mg_connection *co
// Ensure that the content-type is application/json
const char *ct = server->getHeader(conn, string("Content-Type"));

if(ct == NULL || string(ct) != "application/json")
// content type *must* start with application/json
if(ct == NULL || strncmp(ct, "application/json", strlen("application/json")) != 0)
{
mg_send_http_error(conn, 400, "Wrong Content Type");

Expand Down