Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add jasondellaluce to OWNERS #1818

Merged
merged 1 commit into from
Dec 22, 2021

Conversation

jasondellaluce
Copy link
Contributor

Signed-off-by: Jason Dellaluce jasondellaluce@gmail.com

What type of PR is this?

/kind documentation

Any specific area of the project related to this PR?

What this PR does / why we need it:

I would like propose myself as a maintainer of falcosecurity/falco.

After actively contributing to this repository over the past three months, I want to commit to spend my time working on it. I think my case meets the criteria of the process for becoming a maintainer from falcosecurity governance. As such, I would happily to take on the maintainer duties to support Falco's growth and to assist other contributors too.

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

docs: add jasondellaluce to OWNERS

Signed-off-by: Jason Dellaluce <jasondellaluce@gmail.com>
@leogr
Copy link
Member

leogr commented Dec 13, 2021

big +1 for me, as I already said here.

Just waiting for hearing from @falcosecurity/falco-maintainers before giving my approval to this PR :)

@danpop-chainguard
Copy link

+1

@mstemm
Copy link
Contributor

mstemm commented Dec 18, 2021

+1 from me!

@krisnova
Copy link
Contributor

If you meet the criteria there isn’t really much we can say. From a distance i’m fine with it, although it might be worthwhile trying to find some non-sysdig maintainers in the future as well.

Otherwise welcome aboard as far as i’m concerned. 🎉

@krisnova
Copy link
Contributor

krisnova commented Dec 19, 2021

/approve

@poiana
Copy link

poiana commented Dec 19, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jasondellaluce, kris-nova

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana
Copy link

poiana commented Dec 20, 2021

LGTM label has been added.

Git tree hash: 3e21382fd77fb815f07a953462db695ef315363e

@leogr
Copy link
Member

leogr commented Dec 22, 2021

/milestone 0.31.0

@poiana poiana added this to the 0.31.0 milestone Dec 22, 2021
@poiana poiana merged commit 226d1fb into falcosecurity:master Dec 22, 2021
@jasondellaluce jasondellaluce deleted the update/add-me-to-owners branch December 23, 2021 08:11
@fntlnz
Copy link
Contributor

fntlnz commented Jan 9, 2022

@jasondellaluce from the other comments above looks like your organization association (the company who pays your work on this project is with Sysdig). If this is true, please make sure this is reflected here https://github.com/falcosecurity/.github/blob/0773f4bab64ed180d5963eb71363e028e1294a9c/maintainers.yaml#L231

That file is used by CNCF’s devstats and for organizational voting. Please read here https://github.com/falcosecurity/.github/blob/master/GOVERNANCE.md

And welcome onboard! And thanks for the work and effort you are putting in the project.

@jasondellaluce
Copy link
Contributor Author

Hey @fntlnz, thank you for noticing! My name was already in the list, but apparently I was removed by mistake sometime ago. I just opened a PR on test-infra to re-add my record: falcosecurity/test-infra#587

@fntlnz
Copy link
Contributor

fntlnz commented Jan 10, 2022

Cool cool, thank you @jasondellaluce

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants