Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rules): typo in "Create Symlink Over Sensitive Files" rule output #1820

Merged
merged 1 commit into from
Dec 13, 2021

Conversation

deepskyblue86
Copy link
Contributor

@deepskyblue86 deepskyblue86 commented Dec 13, 2021

Signed-off-by: Angelo Puglisi angelopuglisi86@gmail.com

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

If contributing rules or changes to rules, please make sure to also uncomment one of the following line:

/kind rule-update

/kind rule-create

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area engine

/area rules

/area tests

/area proposals

What this PR does / why we need it:
Typo fix in rule output
Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

rule(Create Symlink Over Sensitive File): corrected typo in rule output

Signed-off-by: Angelo Puglisi <angelopuglisi86@gmail.com>
Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thank you!

/approve

@poiana
Copy link

poiana commented Dec 13, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deepskyblue86, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana added the lgtm label Dec 13, 2021
@poiana
Copy link

poiana commented Dec 13, 2021

LGTM label has been added.

Git tree hash: 186d3eadf2cc586a5af1f4bfb53e8f5383b1c4a0

@leogr
Copy link
Member

leogr commented Dec 13, 2021

/milestone 0.31.0

@poiana poiana added this to the 0.31.0 milestone Dec 13, 2021
Copy link
Contributor

@Kaizhe Kaizhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! /lgtm

@poiana poiana merged commit f035829 into falcosecurity:master Dec 13, 2021
@deepskyblue86 deepskyblue86 deleted the senstivie branch December 14, 2021 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants