Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix false-positive of sssd updating /etc/krb5.keytab #1825

Merged
merged 1 commit into from
Feb 11, 2022

Conversation

mac-chaffee
Copy link
Contributor

@mac-chaffee mac-chaffee commented Dec 16, 2021

Signed-off-by: Mac Chaffee me@macchaffee.com

What type of PR is this?
/kind bug
/kind rule-update

Any specific area of the project related to this PR?
/area rules

What this PR does / why we need it:

SSSD is a popular tool for getting Linux machines to interoperate with ActiveDirectory. Part of that process involves invoking adcli to update /etc/krb5.keytab periodically: https://github.com/SSSD/sssd/blob/a664e9ce08ca6c0f9eb2e260b25463eea9c7829b/src/providers/ad/ad_machine_pw_renewal.c#L30

Looks like we already have exceptions for some tools that update this file (centrify_writing_krb), but that exception doesn't include adcli

Which issue(s) this PR fixes:
n/a

Special notes for your reviewer:

Here is an example false positive alert:

"16:34:45.928110723: Error File below /etc opened for writing (user=root user_loginuid=-1 command=adcli update --domain=ad.renci.org --host-fqdn=k8s-node08.k8s.renci.org --computer-password-lifetime=30 --domain-controller=dc1.ad.renci.org parent=sssd_be pcmdline=sssd_be --domain ad.renci.org --uid 0 --gid 0 --logger=files file=/etc/krb5.keytab program=adcli gparent=sssd ggparent=systemd gggparent=<NA> container_id=host image=<NA>) k8s.ns=<NA> k8s.pod=<NA> container=host k8s.ns=<NA> k8s.pod=<NA> container=host k8s.ns=<NA> k8s.pod=<NA> container=host"

Does this PR introduce a user-facing change?:
No.

rules(macro sssd_writing_krb): fixed a false-positive alert that was being generated when SSSD updates /etc/krb5.keytab
rules(macro write_etc_common): fixed a false-positive alert that was being generated when SSSD updates /etc/krb5.keytab

@poiana
Copy link

poiana commented Dec 16, 2021

Welcome @mac-chaffee! It looks like this is your first PR to falcosecurity/falco 🎉

@poiana poiana added the size/XS label Dec 16, 2021
…/krb5.keytab

Signed-off-by: Mac Chaffee <me@macchaffee.com>
@leogr
Copy link
Member

leogr commented Dec 21, 2021

/milestone 0.31.0

@poiana poiana added this to the 0.31.0 milestone Dec 21, 2021
Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Kaizhe PTAL 🙏

@poiana
Copy link

poiana commented Jan 19, 2022

LGTM label has been added.

Git tree hash: 52909705b1ce082e6bb0bbd512d171d5e89e896f

@jasondellaluce jasondellaluce mentioned this pull request Jan 19, 2022
51 tasks
@leogr
Copy link
Member

leogr commented Jan 28, 2022

/milestone 0.32.0

@poiana poiana modified the milestones: 0.31.0, 0.32.0 Jan 28, 2022
@leogr
Copy link
Member

leogr commented Feb 11, 2022

/approve

@poiana
Copy link

poiana commented Feb 11, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leogr, mac-chaffee

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 8a3a4c4 into falcosecurity:master Feb 11, 2022
@jasondellaluce jasondellaluce modified the milestones: 0.32.0, 0.31.1 Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants