-
Notifications
You must be signed in to change notification settings - Fork 886
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix false-positive of sssd updating /etc/krb5.keytab #1825
Conversation
Welcome @mac-chaffee! It looks like this is your first PR to falcosecurity/falco 🎉 |
…/krb5.keytab Signed-off-by: Mac Chaffee <me@macchaffee.com>
/milestone 0.31.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@Kaizhe PTAL 🙏
LGTM label has been added. Git tree hash: 52909705b1ce082e6bb0bbd512d171d5e89e896f
|
/milestone 0.32.0 |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: leogr, mac-chaffee The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Mac Chaffee me@macchaffee.com
What type of PR is this?
/kind bug
/kind rule-update
Any specific area of the project related to this PR?
/area rules
What this PR does / why we need it:
SSSD is a popular tool for getting Linux machines to interoperate with ActiveDirectory. Part of that process involves invoking
adcli
to update /etc/krb5.keytab periodically: https://github.com/SSSD/sssd/blob/a664e9ce08ca6c0f9eb2e260b25463eea9c7829b/src/providers/ad/ad_machine_pw_renewal.c#L30Looks like we already have exceptions for some tools that update this file (
centrify_writing_krb
), but that exception doesn't includeadcli
Which issue(s) this PR fixes:
n/a
Special notes for your reviewer:
Here is an example false positive alert:
Does this PR introduce a user-facing change?:
No.