Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Field properties changes #1838

Merged
merged 2 commits into from
Jan 17, 2022
Merged

Field properties changes #1838

merged 2 commits into from
Jan 17, 2022

Conversation

mstemm
Copy link
Contributor

@mstemm mstemm commented Jan 3, 2022

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

If contributing rules or changes to rules, please make sure to also uncomment one of the following line:

/kind rule-update

/kind rule-create

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area engine

/area rules

/area tests

/area proposals

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Kaizhe
Kaizhe previously approved these changes Jan 3, 2022
@poiana
Copy link

poiana commented Jan 3, 2022

LGTM label has been added.

Git tree hash: 0d4c9422c46ab27876c3d6b80ba3ab22c761dd5e

mstemm and others added 2 commits January 17, 2022 17:29
When listing fields with -N (names only), also skip fields with the
EPF_TABLE_ONLY flag. (Skipping fields without -N is handled in libs,
in the as_string() method).

Signed-off-by: Mark Stemm <mark.stemm@gmail.com>
Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
@leogr
Copy link
Member

leogr commented Jan 17, 2022

/milestone 0.31.0

@poiana poiana added this to the 0.31.0 milestone Jan 17, 2022
Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link

poiana commented Jan 17, 2022

LGTM label has been added.

Git tree hash: ae90d8db31e9381ba041ef418ba1c1ab9ef184ca

@poiana
Copy link

poiana commented Jan 17, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leogr, mstemm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

@jasondellaluce jasondellaluce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana poiana merged commit 3e9f8c1 into master Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants