fix(engine): correctly format json output in json_event

[jasondellaluce]

Signed-off-by: Jason Dellaluce jasondellaluce@gmail.com

What type of PR is this?

/kind bug

Any specific area of the project related to this PR?

/area engine

What this PR does / why we need it:

Due to the changes of #1715, json_event_formatter does not format events properly when the JSON output is enabled. This is caused by the return value not being propagated properly. This seems to be what caused the issues of #1845.

Which issue(s) this PR fixes:

Fixes #1845

Special notes for your reviewer:

This has been tested by building Falco locally from source. Running the following tests without the changes of this PR made me reproduce the issues of #1845, which now seem to be fixed.

mkdir build
cd build
cmake ..
make falco
userspace/falco/falco -r ../rules/k8s_audit_rules.yaml -e ../test/trace_files/k8s_audit/anonymous_creates_namespace_foo.json -o json_output=true

Does this PR introduce a user-facing change?:

fix(engine): correctly format json output in json_event

[leogr]

Good catch! 👏

/approve

[poiana]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jasondellaluce, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jasondellaluce,leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[poiana]

LGTM label has been added.

Git tree hash: c0d2363fa22c4c068ae76fd934ed89be24805644

[leogr]

/milestone 0.31.0
/cc @mstemm