Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new(build): use a dynamic build for the bin/tgz distribution #1853

Merged
merged 3 commits into from
Jan 17, 2022

Conversation

LucaGuerra
Copy link
Contributor

@LucaGuerra LucaGuerra commented Jan 13, 2022

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

If contributing rules or changes to rules, please make sure to also uncomment one of the following line:

/kind rule-update

/kind rule-create

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area engine

/area rules

/area tests

/area proposals

What this PR does / why we need it:

Currently, we distribute a static binary as .tar.gz which is build with musl libc. The build is as static as it gets but it's not possible to load plugins in such a build because they require dynamic loading to be available which cannot be enabled without a dynamic build based on glibc.

In addition, the nodriver image needs to have the proper libraries installed, I propose debian-slim for this.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

build: switch to dynamic build for the binary package (`.tar.gz`)

Signed-off-by: Luca Guerra <luca@guerra.sh>
Signed-off-by: Luca Guerra <luca@guerra.sh>
Signed-off-by: Luca Guerra <luca@guerra.sh>
@leogr
Copy link
Member

leogr commented Jan 13, 2022

/milestone 0.31.0

@poiana poiana added this to the 0.31.0 milestone Jan 13, 2022
@FedeDP
Copy link
Contributor

FedeDP commented Jan 13, 2022

I really like this! Great job @LucaGuerra :)

Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link
Contributor

@jasondellaluce jasondellaluce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link

poiana commented Jan 17, 2022

LGTM label has been added.

Git tree hash: 6b38d1e9eb78cbf5c40f8bbf2f863d0db7089ae4

@poiana
Copy link

poiana commented Jan 17, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jasondellaluce, leogr, LucaGuerra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jasondellaluce,leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@poiana
Copy link

poiana commented Jan 17, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jasondellaluce, leogr, LucaGuerra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jasondellaluce,leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 55ce38c into falcosecurity:master Jan 17, 2022
@leogr leogr mentioned this pull request Jan 26, 2022
51 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants