refactor: remove apt-config utility from debian_packages monitoring #1860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrea Terzolo <andrea.terzolo@polito.it> Co-authored-by: karthikc911 <ckinnovative@gmail.com>
Andreagit97
force-pushed
the
remove_monitoring_of_apt-config
branch
from
e89d794
to
a6c4fa3
Compare
|
/milestone 0.31.0 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Andreagit97, leogr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM label has been added. Git tree hash: 7677aa6385582f8b0e256ca21a1af2846c285622
|
jasondellaluce
approved these changes
Jan 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Andrea Terzolo andrea.terzolo@polito.it
What type of PR is this?
/kind rule-update
Any specific area of the project related to this PR?
/area rules
What this PR does / why we need it:
As suggested by @karthikc911 we could avoid several false positives by removing the
apt-configutility from debian packages monitoring list. I open this PR only because it could be useful to have it merged in Falco 0.31 but @karthikc911 had the original idea. For more details refer to the original Pull Request or to the slack channel.Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?: