Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: updated some warning strings; properly refresh lua files embedded in falco #1864

Merged
merged 7 commits into from
Jan 24, 2022
Merged

fix: updated some warning strings; properly refresh lua files embedded in falco #1864

merged 7 commits into from
Jan 24, 2022

Conversation

FedeDP
Copy link
Contributor

@FedeDP FedeDP commented Jan 24, 2022

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

If contributing rules or changes to rules, please make sure to also uncomment one of the following line:

/kind rule-update

/kind rule-create

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area engine

/area rules

/area tests

/area proposals

What this PR does / why we need it:

  • Any load_rules warning is now printed (not only on verbose mode)
  • Added back a "performance hit" comment when ruleset has a rule without evt.type
  • Check for ignored events warning only when "-A" flag is not actually passed
  • Fixed a lua CMakeLists issue that prevented updated lua files to be refreshed in falco

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@FedeDP
update(userspace/engine,userspace/falco): improved some string warnings.
326a8f5 
Always print warnings while loading rules.
Print a single line when warning for ignored events.

Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
@FedeDP
update(userspace/engine): fixed lua CMakeLists deps, to let it be gra…
68b5d8a 
…cefully rebuilt when lua files are updated.

Moreover, added back warning about performance impact for rules without event types.

Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
@poiana poiana added the size/M label Jan 24, 2022
@FedeDP FedeDP changed the title fix: updated some warning strings; properly refresh lua files embedded in falco build: updated some warning strings; properly refresh lua files embedded in falco Jan 24, 2022
@FedeDP
update(userspace/falco): divide each plugin infos when dumping list o…
ae4123b 
…f plugin with a newline.

Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
@FedeDP @jasondellaluce
update(userspace/engine): updated no evt.type specified lua warning s…
181e7e7 
…tring.

Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
@leogr
Copy link
Member

leogr commented Jan 24, 2022

/milestone 0.31.0

@poiana poiana added this to the 0.31.0 milestone Jan 24, 2022
@leogr leogr mentioned this pull request Jan 24, 2022
Closed
51 tasks
leogr
leogr reviewed Jan 24, 2022
View reviewed changes
Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @FedeDP for fixing these last-minute issues.
SGTM, I have just left some suggestions.

userspace/engine/lua/rule_loader.lua Outdated Show resolved Hide resolved
userspace/engine/rules.cpp Outdated Show resolved Hide resolved
userspace/falco/falco.cpp Outdated Show resolved Hide resolved
userspace/engine/lua/CMakeLists.txt Show resolved Hide resolved
FedeDP and others added 3 commits January 24, 2022 17:15
@FedeDP @leogr
Update userspace/engine/lua/rule_loader.lua
5b7510a 
Signed-off-by: Federico Di Pierro <nierro92@gmail.com>

Co-authored-by: Leonardo Grasso <me@leonardograsso.com>
@FedeDP @leogr
Update userspace/engine/rules.cpp
7789f28 
Signed-off-by: Federico Di Pierro <nierro92@gmail.com>

Co-authored-by: Leonardo Grasso <me@leonardograsso.com>
@FedeDP @leogr
Update userspace/falco/falco.cpp
297443e 
Signed-off-by: Federico Di Pierro <nierro92@gmail.com>

Co-authored-by: Leonardo Grasso <me@leonardograsso.com>
leogr
leogr approved these changes Jan 24, 2022
View reviewed changes
Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now

Thank you

/approve

@poiana poiana added the lgtm label Jan 24, 2022
@poiana
Copy link

poiana commented Jan 24, 2022

LGTM label has been added.

Git tree hash: a26fce13123c83b21561fbe8af6b6d3fdbde0a3c

@poiana
Copy link

poiana commented Jan 24, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

jasondellaluce
jasondellaluce approved these changes Jan 24, 2022
View reviewed changes
Copy link
Contributor

@jasondellaluce jasondellaluce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana poiana merged commit 2f82a9b into falcosecurity:master Jan 24, 2022
@leogr leogr changed the title build: updated some warning strings; properly refresh lua files embedded in falco fix: updated some warning strings; properly refresh lua files embedded in falco Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leogr leogr leogr approved these changes

@jasondellaluce jasondellaluce jasondellaluce approved these changes

@krisnova krisnova Awaiting requested review from krisnova

@leodido leodido Awaiting requested review from leodido

Assignees

@leogr leogr

@jasondellaluce jasondellaluce

Labels
approved area/build area/engine dco-signoff: yes kind/bug lgtm release-note-none size/M
Projects
None yet
Milestone
0.31.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@FedeDP @leogr @poiana @jasondellaluce