Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update(userspace/engine): cleanup unused alternate-lua-dir option and remove config_falco_engine.h.in, now unused since lua scripts are embedded in Falco. #1872

Merged
merged 1 commit into from
Jan 26, 2022

Conversation

FedeDP
Copy link
Contributor

@FedeDP FedeDP commented Jan 26, 2022

Signed-off-by: Federico Di Pierro nierro92@gmail.com

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

If contributing rules or changes to rules, please make sure to also uncomment one of the following line:

/kind rule-update

/kind rule-create

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area engine

/area rules

/area tests

/area proposals

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

update!: removed "--alternate-lua-dir" cmdline option as lua scripts are now embedded in Falco executable.

…remove config_falco_engine.h.in, now unused since lua scripts are embedded in Falco.

Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
@poiana poiana requested review from Kaizhe and leogr January 26, 2022 13:50
@poiana poiana added the size/M label Jan 26, 2022
@leogr leogr changed the title wip: chore(userspace/engine): cleanup unused alternate-lua-dir option and remove config_falco_engine.h.in, now unused since lua scripts are embedded in Falco. chore(userspace/engine): cleanup unused alternate-lua-dir option and remove config_falco_engine.h.in, now unused since lua scripts are embedded in Falco. Jan 26, 2022
@leogr
Copy link
Member

leogr commented Jan 26, 2022

/milestone 0.31.0

@poiana poiana added this to the 0.31.0 milestone Jan 26, 2022
@FedeDP FedeDP changed the title chore(userspace/engine): cleanup unused alternate-lua-dir option and remove config_falco_engine.h.in, now unused since lua scripts are embedded in Falco. update(userspace/engine): cleanup unused alternate-lua-dir option and remove config_falco_engine.h.in, now unused since lua scripts are embedded in Falco. Jan 26, 2022
@leogr leogr mentioned this pull request Jan 26, 2022
51 tasks
Copy link
Contributor

@jasondellaluce jasondellaluce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link

poiana commented Jan 26, 2022

LGTM label has been added.

Git tree hash: 0c31fb57d817aa00313fca706185d092d7967b44

Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link

poiana commented Jan 26, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP, jasondellaluce, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jasondellaluce,leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 8d9dd44 into falcosecurity:master Jan 26, 2022
@FedeDP FedeDP deleted the cleanup_alternate_lua_dir branch January 26, 2022 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants