Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update(falco): updates usage description for -o, --option #1903

Merged
merged 1 commit into from
Feb 21, 2022

Conversation

andreabonanno
Copy link
Contributor

Signed-off-by: Andrea Bonanno andrea@bonanno.cloud

What type of PR is this?

Any specific area of the project related to this PR?

What this PR does / why we need it:

Updates Falco usage text for -o, --option, so it reflects the update of #1792

Which issue(s) this PR fixes:
Fixes #1898

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@jasondellaluce
Copy link
Contributor

Thank you @andreabonanno! I would also explicit the fact that array-like notations can be used too. For example, the following is allowed: plugins[0].init_config="hello".

Signed-off-by: Andrea Bonanno <andrea@bonanno.cloud>
@leogr
Copy link
Member

leogr commented Feb 21, 2022

/milestone 0.32.0

Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link

poiana commented Feb 21, 2022

LGTM label has been added.

Git tree hash: 5c6f2c1fa514b43f95ccec1f324ba914ae370891

@leogr
Copy link
Member

leogr commented Feb 21, 2022

/approved

@leogr
Copy link
Member

leogr commented Feb 21, 2022

/approve

@poiana
Copy link

poiana commented Feb 21, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreabonanno, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 888c15c into falcosecurity:master Feb 21, 2022
@jasondellaluce jasondellaluce added this to the 0.31.1 milestone Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Help message for -o, --option is not accurate
4 participants