new: add a new drop category n_drops_scratch_map
#1916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/retest |
Signed-off-by: Andrea Terzolo <andrea.terzolo@polito.it>
Andreagit97
force-pushed
the
add_new_drop_type
branch
2 times, most recently
from
2d99c8b
to
773c454
Compare
Signed-off-by: Andrea Terzolo <andrea.terzolo@polito.it>
Andreagit97
force-pushed
the
add_new_drop_type
branch
from
773c454
to
a4b4c27
Compare
jasondellaluce
approved these changes
Mar 1, 2022
|
LGTM label has been added. Git tree hash: f7ab0a6bdcc260f590bd4c7cee9b64a195643b14
|
|
/milestone 0.32.0 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Andreagit97, jasondellaluce, leogr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Andrea Terzolo andrea.terzolo@polito.it
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area engine
What this PR does / why we need it:
This PR allows computing the delta also for
scratch_mapdrops.The
scratch_mapdrops are a new drop category introduced here.These drops are related only to the bpf probe: a
scratch_mapdrop happens when an event is too large and cannot be saved into theframe_scratch_mapbefore being sent to userspace. The idea here is to clearly separate drops due to a full buffer from those caused by events that are too large. For more information take a look at this PR 👇falcosecurity/libs#224
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?: