refactor(userspace/falco): re-design stats writer and make it thread-safe #2109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/milestone 0.33.0 |
15 tasks
FedeDP
reviewed
Jul 6, 2022
jasondellaluce
force-pushed
the
refactor/stats-writer
branch
from
dd08ea6
to
95138c4
Compare
This new model uses an async worker and a concurrent queue to handle stats writing. This ensures better performance, because the live event processing loop will just need to do a push on the queue instead of writing to a file (only when the timer triggers), and should be thread-safe by design. Signed-off-by: Jason Dellaluce <jasondellaluce@gmail.com>
Signed-off-by: Jason Dellaluce <jasondellaluce@gmail.com>
…ction Signed-off-by: Jason Dellaluce <jasondellaluce@gmail.com>
Signed-off-by: Jason Dellaluce <jasondellaluce@gmail.com>
Signed-off-by: Jason Dellaluce <jasondellaluce@gmail.com>
Signed-off-by: Jason Dellaluce <jasondellaluce@gmail.com>
Signed-off-by: Jason Dellaluce <jasondellaluce@gmail.com>
jasondellaluce
force-pushed
the
refactor/stats-writer
branch
from
95138c4
to
efa9af2
Compare
leogr
reviewed
Aug 26, 2022
Co-authored-by: Leonardo Grasso <me@leonardograsso.com> Signed-off-by: Jason Dellaluce <jasondellaluce@gmail.com>
Co-authored-by: Leonardo Grasso <me@leonardograsso.com> Signed-off-by: Jason Dellaluce <jasondellaluce@gmail.com>
|
LGTM label has been added. Git tree hash: e61f31be02c7064be6b4fa5fbd89818ee880587c
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FedeDP, jasondellaluce The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
/kind design
Any specific area of the project related to this PR?
/area engine
What this PR does / why we need it:
As for the requirements of #2074, this PR refactors the stats writer of Falco to make it thread-safe. The class has been re-designed as a whole with a multi-producer single-consumer model with a worker and a queue (similar to what we have in the output framework). Moreover, this approach should also perform a little better because during the event processing loop we now push on the queue instead of writing on the file buffer (it just happens once in a while when the periodic timeout ticks, so it's not a big deal). This design also make it easier to add new stats field if needed in the future.
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?: